make download-rustc="if-unchanged" default for library profile
#132494
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: onur-ozkan <work@onurozkan.dev>
rustbot
added
S-waiting-on-review
|
This PR modifies If appropriate, please update |
Signed-off-by: onur-ozkan <work@onurozkan.dev>
onur-ozkan
commented
Nov 2, 2024
jieyouxu
approved these changes
Nov 2, 2024
onur-ozkan
force-pushed
the
library-profile-default
branch
from
c4c0e3e
to
329dacf
Compare
jieyouxu
approved these changes
Nov 2, 2024
|
@bors r=jieyouxu |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 2, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#132481 (rustdoc: skip stability inheritance for some item kinds) - rust-lang#132482 (library: fix some stability annotations) - rust-lang#132493 (Fix type reference in documents which was being confused with html tags.) - rust-lang#132494 (make `download-rustc="if-unchanged"` default for library profile) - rust-lang#132495 (Remove unintended link) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 2, 2024
Rollup merge of rust-lang#132494 - onur-ozkan:library-profile-default, r=jieyouxu make `download-rustc="if-unchanged"` default for library profile Since `download-rustc` is tested on CI and rust-lang#132267 makes it effective for library development, we can now make it default for the library profile. Implements the 3rd item from [this tracking issue](rust-lang#131744).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
download-rustcis tested on CI and #132267 makes it effective for library development, we can now make it default for the library profile.Implements the 3rd item from this tracking issue.